feat(terminal): add per-provider custom CLI arguments#2692
Conversation
feat(terminal): add custom CLI arguments setting for terminal launcher Allow users to configure additional CLI arguments (e.g. --dangerously-skip-permissions) that are appended to the command when opening a provider terminal. The setting is available in Settings > General > Terminal Settings and applies to all platforms. @
Allow users to configure additional CLI arguments (e.g. --dangerously-skip-permissions) per provider via ProviderMeta.customCliArgs. When opening a terminal for a provider, the args are appended to the launch command. The setting is available in the provider edit form under "Advanced Config".
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ea093cd76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Claude finished @farion1231's task in 2m 25s —— View job ReviewLGTM — no blocking issues. Walked through the diff in detail. Summary of what I checked:
Minor observation (non-blocking, intentional given the commit message):
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bf2e7a251
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…batch argument escaping
… customCliArgs references
# Conflicts: # src-tauri/src/session_manager/providers/openclaw.rs
Chizukuo
force-pushed
the
feat/custom-cli-args
branch
from
28392f7 to
7b62d7f
Compare
|
To use Codex here, create a Codex account and connect to github. |
# Conflicts: # src-tauri/src/commands/misc.rs
2 participants
Allow users to configure additional CLI arguments (e.g. --dangerously-skip-permissions) per provider via ProviderMeta.customCliArgs. When opening a terminal for a provider, the args are appended to the launch command. The setting is available in the provider edit form under "Advanced Config".
Summary / 概述
This PR adds support for per-provider custom CLI arguments (e.g.
--dangerously-skip-permissions). This is implemented by adding a newcustomCliArgsfield toProviderMetawhich allows users to configure additional parameters in the "Advanced Config" section of the provider edit form. When a terminal is launched for a specific provider, these custom arguments are automatically appended to the underlying launch command (such asclaude --settings <path> [custom_args]).本 PR 添加了针对不同供应商配置自定义 CLI 启动参数的支持（例如
--dangerously-skip-permissions）。在编辑供应商表单的“高级配置”中新增了对应输入框，并将其存入ProviderMeta.customCliArgs。当为特定供应商启动终端时，这些自定义参数将自动附加在最终的启动命令末尾。Related Issue / 关联 Issue
Fixes # [填写相关的Issue编号，若无则保留空]
Screenshots / 截图
Advanced Config无自定义 CLI 参数输入框Advanced Config显示新的自定义 CLI 参数输入框并有对应提示信息Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查（如修改了 Rust 代码）